Merge pull request #342 from Ubiquiti-App/feature/UCRM-6365-kmz-plugi…

…n-fix-deprecated UCRM 6365 - KMZ plugin - deprecated fix
Ubiquiti-App · Dec 4, 2024 · 50f38c9 · 50f38c9
2 parents 04a8754 + 1804f7d
commit 50f38c9
Show file tree

Hide file tree

Showing 10 changed files with 11 additions and 14 deletions.
diff --git a/plugins.json b/plugins.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": "2.1.0"

diff --git a/plugins/kmz-map/kmz-map.zip b/plugins/kmz-map/kmz-map.zip
diff --git a/plugins/kmz-map/src/includes/config.class.php b/plugins/kmz-map/src/includes/config.class.php
@@ -16,7 +16,7 @@ class Config
 
     public static $LINK_TWO = null;
 
-    public static function initializeStaticProperties($config_path)
+    public static function initializeStaticProperties($config_path): void
     {
 
     // ## Setup user configuration settings, if they exist
@@ -26,16 +26,13 @@ public static function initializeStaticProperties($config_path)
             $config_json = json_decode($config_string);
 
             foreach ($config_json as $key => $value) {
-
-        // ## Expect specific key naming convention
                 $name = false;
-                $count = false;
                 if (strpos($key, 'REQUIRED_') !== false) {
                     $name = str_replace('REQUIRED_', '', $key);
                     $new_value = $value;
                 } elseif (strpos($key, 'HYPER_LINK_') !== false) {
                     $name = str_replace('HYPER_LINK_', '', $key);
-                    $new_value = self::parseLink($value);
+                    $new_value = self::parseLink((string) $value);
                 } elseif (strpos($key, 'OPTIONAL_') !== false) {
                     $name = str_replace('OPTIONAL_', '', $key);
                     $new_value = $value;
@@ -54,7 +51,7 @@ public static function initializeStaticProperties($config_path)
         }
     }
 
-    private static function parseLink($link_string)
+    private static function parseLink(string $link_string): array
     {
         return explode('|', $link_string, 2);
     }

diff --git a/plugins/kmz-map/src/manifest.json b/plugins/kmz-map/src/manifest.json
@@ -5,7 +5,7 @@
     "displayName": "KMZ Map",
     "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
     "url": "https://github.com/Ubiquiti-App/UCRM-plugins/tree/master/plugins/kmz-map",
-    "version": "1.2.0",
+    "version": "1.2.1",
     "unmsVersionCompliancy": {
       "min": "1.0.0",
       "max": null

diff --git a/plugins_2.1.x.json b/plugins_2.1.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null

diff --git a/plugins_2.2.x.json b/plugins_2.2.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null

diff --git a/plugins_2.3.x.json b/plugins_2.3.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null

diff --git a/plugins_2.4.x.json b/plugins_2.4.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null

diff --git a/plugins_2.5.x.json b/plugins_2.5.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null

diff --git a/plugins_3.0.x.json b/plugins_3.0.x.json
@@ -70,7 +70,7 @@
             "displayName": "KMZ Map",
             "description": "A UISP CRM plugin that provides a frontend Google Map for clients to view tower coverage.",
             "url": "https:\/\/github.com\/Ubiquiti-App\/UCRM-plugins\/tree\/master\/plugins\/kmz-map",
-            "version": "1.2.0",
+            "version": "1.2.1",
             "unmsVersionCompliancy": {
                 "min": "1.0.0",
                 "max": null