Set path to null by default in TryGetPath() for consistency

UglyToad · Jan 15, 2024 · bcb6a4e · bcb6a4e
1 parent d6e3ddb
commit bcb6a4e
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/UglyToad.PdfPig.Fonts/TrueType/TrueTypeFont.cs b/src/UglyToad.PdfPig.Fonts/TrueType/TrueTypeFont.cs
@@ -137,7 +137,7 @@ public bool TryGetBoundingBox(int characterCode, Func<int, int?> characterCodeTo
         /// </summary>
         public bool TryGetPath(int characterCode, Func<int, int?> characterCodeToGlyphId, out IReadOnlyList<PdfSubpath> path)
         {
-            path = EmptyArray<PdfSubpath>.Instance;
+            path = null;
 
             if (!TryGetGlyphIndex(characterCode, characterCodeToGlyphId, out var index)
                 || TableRegister.GlyphTable == null)

diff --git a/src/UglyToad.PdfPig.Tests/Integration/VisualVerification/GenerateLetterGlyphImages.cs b/src/UglyToad.PdfPig.Tests/Integration/VisualVerification/GenerateLetterGlyphImages.cs
@@ -64,8 +64,6 @@ private static void Run(string file, int pageNo = 1)
                 var page = document.GetPage(pageNo);
                 var size = new SKSizeI((int)(page.Width * Scale), (int)(page.Height * Scale));
 
-                var annots = page.ExperimentalAccess.GetAnnotations().ToArray();
-
                 using (var picture = document.GetPage<SKPicture>(pageNo))
                 using (var image = SKImage.FromPicture(picture, size, ScaleMatrix))
                 using (var bmp = SKBitmap.FromImage(image))

diff --git a/src/UglyToad.PdfPig/PdfFonts/CidFonts/PdfCidCompactFontFormatFont.cs b/src/UglyToad.PdfPig/PdfFonts/CidFonts/PdfCidCompactFontFormatFont.cs
@@ -120,7 +120,7 @@ private CompactFontFormatFont GetFont()
 
         public bool TryGetPath(int characterCode, out IReadOnlyList<PdfSubpath> path)
         {
-            path = EmptyArray<PdfSubpath>.Instance;
+            path = null;
 
             var font = GetFont();
 

diff --git a/src/UglyToad.PdfPig/PdfFonts/Simple/TrueTypeSimpleFont.cs b/src/UglyToad.PdfPig/PdfFonts/Simple/TrueTypeSimpleFont.cs
@@ -328,7 +328,7 @@ public bool TryGetPath(int characterCode, out IReadOnlyList<PdfSubpath> path)
         {
             if (font == null)
             {
-                path = EmptyArray<PdfSubpath>.Instance;
+                path = null;
                 return false;
             }