Allow reading orders dectors to support any class that has a bounding box/PdfRectangle #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… box/PdfRectangle - Introduce IBoundingBox interface
davebrokit
commented
Jun 26, 2024
| { | ||
| using Core; | ||
| using Graphics.Colors; | ||
| namespace UglyToad.PdfPig.Content |
There was a problem hiding this comment.
Not sure what happened here (Formating tabs/whitespace?). Only added interface and
/// <summary>
/// Gets the Bounding Box: The rectangle completely containing this object
/// </summary>
public PdfRectangle BoundingBox => GlyphRectangle;
davebrokit
commented
Jun 28, 2024
| public IEnumerable<TBlock> Get<TBlock>(IEnumerable<TBlock> blocks) | ||
| where TBlock : IBoundingBox | ||
| { | ||
| if (typeof(TBlock) != typeof(TextBlock)) |
There was a problem hiding this comment.
Should we throw here instead?
This reading order detector would only work with type TextBlock. Should we throw when the type is not that? Right now just return the enumerable as is
|
Need to do some refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#855