Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddCoolingProfile.py #20024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Dec 12, 2024

Description

Added an option for dual-extruder printers with independent layer cooling fans. Normally the fan shuts off when a nozzle finishes. This option allows the user to select a speed that the layer cooling fan of the inactive nozzle will remain at during it's idle time (rather than "S0").
This was requested in #2149 (July of 2017) to help reduce oozing.

A change a made from the original was to replace all the "##" with single "#". That makes it look like there were a lot of changes, but the substantive changes are:

  1. Added 3 settings.
  2. Pass the "fan_mode" and "off_fan_speed" variables to various functions.

Type of change

  • [ X] New feature (non-breaking change which adds functionality)

Test Configuration:

  • Operating System: Win 10 Pro
  • Various Cura versions

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Test Results

23 370 tests  ±0   23 248 ✅ ±0   56s ⏱️ +2s
     1 suites ±0        2 💤 ±0 
     1 files   ±0      120 ❌ ±0 

For more details on these failures, see this check.

Results for commit 8d5dd77. ± Comparison against base commit cca70d8.

♻️ This comment has been updated with latest results.

Added an option for dual-extruder printers to have the fan of the inactive nozzle remain on at a set speed to help reduce oozing.

Update AddCoolingProfile.py
Only enable the new option when the extruders have different fan numbers.

Had another thought.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant