Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Details Page - A typo was there in the last pr #407

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Varghab
Copy link
Contributor

@Varghab Varghab commented Jul 6, 2023

Related Issue

  • Information about the related issue

Closes: #166

Describe the changes you've made

The changes were not reflected in the main site as there was a small error with the Link component.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jul 6, 2023

@Varghab is attempting to deploy a commit to the unikonf-vibey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

@Deepu178
Copy link
Collaborator

Deepu178 commented Jul 6, 2023

@Varghab there was a production error in your last pr. can you please check it out?

@Varghab
Copy link
Contributor Author

Varghab commented Jul 6, 2023

@Deepu178 Would you tell me the exact error? My code has reflected in the main branch but not working properly when clicked on the specific event.

@Deepu178
Copy link
Collaborator

Deepu178 commented Jul 6, 2023

@Varghab you can run your code in production locally and you will get the error.
Build optimization failed: found page without a React Component as default export in
pages/events/eventsData

@Varghab
Copy link
Contributor Author

Varghab commented Jul 6, 2023

@Deepu178 My code is working fine locally. I guess the issue is arising from events_data file.

@Deepu178
Copy link
Collaborator

Deepu178 commented Jul 6, 2023

did you try running @Varghab
pnpm run build and if yes is it working fine?

@Varghab
Copy link
Contributor Author

Varghab commented Jul 6, 2023

@Deepu178 I guess I figured out the issue, this is probably happening because I have used eventsData.tsx instead of _eventsData.tsx

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ❌ Failed (Inspect) Jul 6, 2023 10:37am

@Varghab
Copy link
Contributor Author

Varghab commented Jul 6, 2023

@Deepu178 I have fixed the issue, merging this PR should work.

@Deepu178
Copy link
Collaborator

Deepu178 commented Jul 6, 2023

No, it will not fix the error @Varghab like if you want I can fix the issue

@Varghab
Copy link
Contributor Author

Varghab commented Jul 6, 2023

@Deepu178 Do you know why is that happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Dedicated page for each events
2 participants