-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typedoc from 0.25.4 to 0.27.4 and add better CI integration #1244
Conversation
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.4 to 0.27.2. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.25.4...v0.27.2) --- updated-dependencies: - dependency-name: typedoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR breaks documentation building. We'll need to figure out why and fix compatibility.
dkatz@dkatz-VirtualBox:~/universalviewer$ npm run docs
> [email protected] docs
> typedoc --plugin typedoc-plugin-missing-exports
[error] The plugin typedoc-plugin-missing-exports could not be loaded
[error] Error [ERR_REQUIRE_ESM]: require() of ES Module /home/dkatz/universalviewer/node_modules/typedoc/dist/index.js from /home/dkatz/universalviewer/node_modules/typedoc-plugin-missing-exports/index.js not supported.
Instead change the require of /home/dkatz/universalviewer/node_modules/typedoc/dist/index.js in /home/dkatz/universalviewer/node_modules/typedoc-plugin-missing-exports/index.js to a dynamic import() which is available in all CommonJS modules.
at Object.<anonymous> (/home/dkatz/universalviewer/node_modules/typedoc-plugin-missing-exports/index.js:5:19)
[error] Found 2 errors and 0 warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get this to build by updating the plugin dependency to a compatible version. I then rebuilt the docs, which changed a large number of files. At a glance, the documentation still looks correct, but I'm not sure what needs to be validated in detail. I'd appreciate more input from others before merging this.
A newer version of typedoc exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
I've made a few further adjustments here: 1.) I've added a GitHub Actions rule which automatically builds the documentation; this will keep things up to date for us automatically. 2.) Part of the GitHub Actions rule includes the regeneration of the docs/CNAME file (which I assume is needed for our deployment workflow); this gets destroyed every time typedoc runs otherwise. 3.) I discovered that every time you run typedoc, it links to the most recent commit ID on GitHub in every file... this means that literally every time you commit anything, all of the documentation changes. I changed this to instead pin links to the dev branch, so users will see the most recent code. This has some downsides, but I think it's preferable to adding hundreds of file changes to every pull request. Since documentation updates will be automatic going forward, I think it makes sense for the published documentation to point to the bleeding edge code. I'm open to discussing other options, though! |
Bumps typedoc from 0.25.4 to 0.27.2.
Release notes
Sourced from typedoc's releases.
... (truncated)
Changelog
Sourced from typedoc's changelog.
... (truncated)
Commits
23e2c99
Update changelog for releaseb6b9b01
Bump version to 0.27.2ea631e0
Fix external.d.ts unit test7d38048
Fix crash with TS 5.5.xc3842c1
Minor improvements to API docs663ce54
Add maintenance status to site193b02e
Simplify plugin/theme list generation on site9a520d7
Simpler handling of changelog in site6142a5e
Update changelog for release1ce36a4
Bump version to 0.27.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)