feat/yggdrasil feature enabled #259
Conversation
| @@ -22,7 +22,14 @@ public String getToggleName() { | |||
|
|
|||
| public Variant getExpectedResult() { | |||
| if (expectedResult.getName().equals("disabled")) { | |||
| return Variant.DISABLED_VARIANT; | |||
| Variant clone = | |||
| new Variant( | |||
There was a problem hiding this comment.
This seems really dumb, is there a better way to clone an object without making a copy constructor?
There was a problem hiding this comment.
You can have a clone method that does this for you, but the code will be there... I remember there were some utility methods, but atm I think this is fine
pom.xml
Outdated
| @@ -10,7 +10,7 @@ | |||
| <version.junit5>5.10.3</version.junit5> | |||
| <version.okhttp>4.12.0</version.okhttp> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <version.unleash.specification>5.1.5</version.unleash.specification> | |||
| <version.unleash.specification>5.1.9</version.unleash.specification> | |||
There was a problem hiding this comment.
Does it work well with #260 where you had to roll down?
There was a problem hiding this comment.
It does not! It's on the list of things to do prior to release - a proper set of tests around Windows + unicode. But this is okay for now so these PRs don't get too big I think
| @@ -22,7 +22,14 @@ public String getToggleName() { | |||
|
|
|||
| public Variant getExpectedResult() { | |||
| if (expectedResult.getName().equals("disabled")) { | |||
| return Variant.DISABLED_VARIANT; | |||
| Variant clone = | |||
| new Variant( | |||
There was a problem hiding this comment.
You can have a clone method that does this for you, but the code will be there... I remember there were some utility methods, but atm I think this is fine
Forces the Java SDK to resolve feature enabled from Yggdrasil rather than computing it separately from isEnabled + getVariant