Feat: add rbs support #123
Draft
+152
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarruda
force-pushed
the
feat/add_rbs
branch
from
d697eb8 to
ed318dd
Compare
Pull Request Test Coverage Report for Build 12877559180Details
💛 - Coveralls |
rarruda
force-pushed
the
feat/add_rbs
branch
from
585f1a9 to
891a396
Compare
TODO: - add rbs to gemspec - add rbs tests to gha - add rbs tests - consider checking using steep / Steepfile
- added steep and rbs to gemspec - added type signature tests to github actions - updated Steepfile
apparently i don't run all tests in all platforms locally
|
Note: worth while considering: https://github.com/soutaro/rbs-inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Add support for type checking/hinting in the SDK.
Should be quite helpful for users if they have a powerful IDE, and for developers to ensure that we correctly handle the correct types in methods, etc.
Important files
Discussion points
Not sure if all the essential client-code is yet in place.
Basic testing is however in place via github actions / steep