Handle empty metrics after 10 min #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
commented
Dec 10, 2024
| @@ -534,15 +534,15 @@ end | |||
| ## Development | |||
|
|
|||
| After checking out the repo, run `bin/setup` to install dependencies. | |||
| Then, run `rake spec` to run the tests. | |||
| Then, run `bundle exec rake spec` to run the tests. | |||
There was a problem hiding this comment.
At least in my machine I needed to add exec and other places in this readme also uses exec so I think this is the safest
Pull Request Test Coverage Report for Build 12263142735Details
💛 - Coveralls |
nunogois
reviewed
Dec 10, 2024
nunogois
reviewed
Dec 10, 2024
| platformVersion: anything, | ||
| bucket: {} | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is this working as expected? I thought the intention would be not to post to server when it's empty.
There was a problem hiding this comment.
Nvm, we're subtracting by 10 minutes and 1 second, which means that the second part of our condition is not met, so we post the empty metrics. Got it 👍
There was a problem hiding this comment.
Indeed, turns out this code path was apparently not tested and didn't work as expected. Although it's an edge case I think it makes sense
Co-authored-by: Nuno Góis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This PR adds a test to validate what happens when metrics are empty for more than 10 minutes. This other PR #218 tested that it was actually failing.
We've also validated that nil bucket returns a 400 from Unleash server side so instead we should always fallback to an empty bucket.