Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor cleanup after #618 #621

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jan 6, 2025

This PR performs a small amount of cleanup after #618 based on the PR discussion. Specifically, it:

  • Adds a new project_filter_from_projects function to the filters file, and makes project_filter fall back to that on the back end (we can discuss the names here, but doing it this way saved me touching any more code)
  • Reverts the std::mem::take shenanigans in favor of cloning. Even though it clones one string per attached listener every 30 seconds, it's probably not going to cause a lot of memory overhead given that we drop the original shortly thereafter.

Copy link

github-actions bot commented Jan 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@thomasheartman thomasheartman requested review from sighphyre and chriswk and removed request for sighphyre January 7, 2025 08:42
@thomasheartman thomasheartman enabled auto-merge (squash) January 7, 2025 13:34
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :)

This was referenced Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants