fix: add meta to support new format #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaanus
requested review from
chriswk and
sighphyre
and removed request for
chriswk
Dependency ReviewThe following issues were found:
License Issuesserver/Cargo.toml
Denied Licenses: GPL-1.0, GPL-2.0, GPL-3.0, LGPL-2.1, LGPL-3.0, AGPL-3.0 OpenSSF ScorecardScorecard details
Scanned Files
|
sighphyre
approved these changes
Jan 7, 2025
chriswk
approved these changes
Jan 7, 2025
|
Got the build working, but I suspect it should not be None always, but it should pass this value forward from Unleash. |
sjaanus
commented
Jan 8, 2025
server/src/feature_cache.rs
Outdated
| @@ -99,6 +99,7 @@ fn update_client_features( | |||
| s | |||
| }), | |||
| query: old.query.clone().or(update.query.clone()), | |||
| meta: None, | |||
There was a problem hiding this comment.
Should this be old.meta.clone()
There was a problem hiding this comment.
Hmm, probably update.meta.clone().or(old.meta.clone())
sjaanus
commented
Jan 8, 2025
server/src/filters.rs
Outdated
| @@ -48,6 +48,7 @@ pub(crate) fn filter_client_features( | |||
| segments: feature_cache.segments.clone(), | |||
| query: feature_cache.query.clone(), | |||
| version: feature_cache.version, | |||
| meta: None, | |||
There was a problem hiding this comment.
Should this be feature_cache.meta.
sjaanus
commented
Jan 8, 2025
| @@ -90,6 +90,7 @@ pub enum TokenType { | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug)] | |||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
Got error
error: large size difference between variants
--> server/src/types.rs:93:1
|
93 | / pub enum ClientFeaturesResponse {
94 | | NoUpdate(EntityTag),
| | ------------------- the second-largest variant contains at least 32 bytes
95 | | Updated(ClientFeatures, Option<EntityTag>),
| | ------------------------------------------ the largest variant contains at least 256 bytes
96 | | }
| |_^ the entire enum is at least 256 bytes
chriswk
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get tip of main working, but some tests are failing.
I suspect it is related to the new meta field, I added it to all obvious places, but I think its more complex.