chore: remove compiler flag for delta #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
chriswk
approved these changes
Jan 16, 2025
Comment on lines
+225
to
226
| #[clap(long, env, default_value_t = false, conflicts_with = "delta")] | ||
| pub delta_diff: bool, |
There was a problem hiding this comment.
so you can't have both delta_diff and delta, might be worth it to consider looking at arg_groups, but for now, this will work fine. 👍
There was a problem hiding this comment.
delta_diff probably needs to come out before release anyway, that's only useful for debug
This was referenced Jan 17, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove delta compiler flag, so we do not need to compile it manually. Feature flag is enough.