fix: make sessionId be a string when set automatically (#229)

package.json

@@ -86,5 +86,6 @@
     "rules": {
       "@typescript-eslint/no-explicit-any": "off"
     }
-  }
+  },
+  "packageManager": "[email protected]+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72"
 }

src/index.test.ts

@@ -164,9 +164,8 @@ test('Should read session id from localStorage', async () => {
         public async get(name: string) {
             if (name === 'sessionId') {
                 return sessionId;
-            } else {
-                return Promise.resolve([]);
             }
+            return Promise.resolve([]);
         }
     }
 
@@ -183,6 +182,35 @@ test('Should read session id from localStorage', async () => {
     expect(context.sessionId).toBe(sessionId);
 });
 
+test('Should send sessionId as string, even if it was saved a number', async () => {
+    const sessionId = 123;
+    fetchMock.mockReject();
+
+    class Store implements IStorageProvider {
+        public async save() {
+            return Promise.resolve();
+        }
+
+        public async get(name: string) {
+            if (name === 'sessionId') {
+                return sessionId;
+            }
+            return Promise.resolve([]);
+        }
+    }
+
+    const storageProvider = new Store();
+    const config: IConfig = {
+        url: 'http://localhost/test',
+        clientKey: '12',
+        appName: 'web',
+        storageProvider,
+    };
+    const client = new UnleashClient(config);
+    await client.start();
+    const context = client.getContext();
+    expect(context.sessionId).toBe('123');
+});
 test('Should read toggles from localStorage', async () => {
     jest.spyOn(global.console, 'error').mockImplementation(() => jest.fn());
     const toggles = [

src/index.ts

@@ -458,9 +458,9 @@ export class UnleashClient extends TinyEmitter {
         let sessionId = await this.storage.get('sessionId');
         if (!sessionId) {
             sessionId = Math.floor(Math.random() * 1_000_000_000);
-            await this.storage.save('sessionId', sessionId);
+            await this.storage.save('sessionId', sessionId.toString(10));
         }
-        return sessionId;
+        return sessionId.toString(10);
     }
 
     private getHeaders() {