fix: ready state when bootstrapping (#218)

* fix: ready state when bootstrapping * refactor: fetched from server internal state
Unleash · Jun 26, 2024 · de95fe4 · de95fe4
1 parent e2586b2
commit de95fe4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -1756,3 +1756,28 @@ describe('READY event emission', () => {
         expect(client.emit).toHaveBeenCalledWith(EVENTS.READY);
     });
 });
+
+test('should be in ready state if bootstrapping', (done) => {
+    const config: IConfig = {
+        url: 'http://localhost/test',
+        clientKey: '12',
+        appName: 'web',
+        bootstrap: [
+            {
+                enabled: false,
+                name: 'test-frontend',
+                variant: { name: 'some-variant', enabled: false },
+                impressionData: false,
+            },
+        ],
+        fetch: async () => {},
+    };
+
+    const client = new UnleashClient(config);
+
+    client.on(EVENTS.READY, () => {
+        expect(client.isReady()).toBe(true);
+        client.stop();
+        done();
+    });
+});
diff --git a/src/index.ts b/src/index.ts
@@ -147,6 +147,7 @@ export class UnleashClient extends TinyEmitter {
     private eventsHandler: EventsHandler;
     private customHeaders: Record<string, string>;
     private readyEventEmitted = false;
+    private fetchedFromServer = false;
     private usePOSTrequests = false;
     private started = false;
     private sdkState: SdkState;
@@ -291,7 +292,7 @@ export class UnleashClient extends TinyEmitter {
     }
 
     private async updateToggles() {
-        if (this.timerRef || this.readyEventEmitted) {
+        if (this.timerRef || this.fetchedFromServer) {
             await this.fetchToggles();
         } else if (this.started) {
             await new Promise<void>((resolve) => {
@@ -361,6 +362,8 @@ export class UnleashClient extends TinyEmitter {
         ) {
             await this.storage.save(storeKey, this.bootstrap);
             this.toggles = this.bootstrap;
+            this.sdkState = 'healthy';
+            this.readyEventEmitted = true;
             this.emit(EVENTS.READY);
         }
 
@@ -482,9 +485,10 @@ export class UnleashClient extends TinyEmitter {
                         this.sdkState = 'healthy';
                     }
 
-                    if (!this.readyEventEmitted) {
-                        this.emit(EVENTS.READY);
+                    if (!this.fetchedFromServer) {
+                        this.fetchedFromServer = true;
                         this.readyEventEmitted = true;
+                        this.emit(EVENTS.READY);
                     }
                 } else if (!response.ok && response.status !== 304) {
                     console.error(