Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert to commonjs #174

Closed
wants to merge 2 commits into from
Closed

fix: revert to commonjs #174

wants to merge 2 commits into from

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Oct 16, 2023 •
edited
Loading

Fixes #173

We are not ready to support ESM yet. Reverting back to CommonJS, so we don't break build.

sighphyre
sighphyre reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, the tests seem to be upset tho

@sighphyre sighphyre requested a review from Tymek October 16, 2023 11:23
sighphyre
sighphyre approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

@sjaanus sjaanus closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

@Tymek Tymek Awaiting requested review from Tymek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommonJS imports are broken in v3.0.0
2 participants
@sjaanus @sighphyre