fix: don't enter error state when request is aborted #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Prevents the SDK entering the error state when a request is aborted. An aborted request doesn't indicate that there's an error, only that a new request has superseded the previous one.
An example of the current behavior:
initializing
stateflags A
userId
flags B
flags A
cancelled <- transitions toerror
stateflags B
completed <- transitions tohealthy
stateExpected behavior:
initializing
stateflags A
userId
flags B
flags A
cancelled <- remains ininitializing
stateflags B
completed <- transitions tohealthy
stateI noticed this because in our case Sentry captures
console.error
messages, and we are seeing a lot of Sentry issues due to theconsole.error
in the catch handler.