feat(1 3223): add client identification headers #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
reviewed
Jan 7, 2025
kwasniew
reviewed
Jan 7, 2025
kwasniew
reviewed
Jan 7, 2025
kwasniew
approved these changes
Jan 7, 2025
thomasheartman
deleted the
feat(1-3223)/add-client-identification-headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds client identification headers to the feature and metrics calls that the client makes to Unleash. The headers are:
x-unleash-appname: the name of the application that is using the clientx-unleash-connection-id: a unique identifier for the current instance of the clientx-unleash-sdk: sdk information in the formatunleash-js@<version>Discussion points:
What should we call the client here? Is
unleash-jscorrect? Should it beunleash-browser?unleash-proxy-client?Second: should the client be possible to override? This package is also what powers our React, Svelte, and Vue SDKs. Should they be able to override it (so you'd get
unleash-react@<version>)? I think that would be useful