Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Force stop before start #74

Merged
merged 4 commits into from
Nov 21, 2023
Merged

fix: Force stop before start #74

merged 4 commits into from
Nov 21, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 20, 2023 •
edited
Loading

About the changes

Forcing stop before start at the client level (client is the orchestrator). It leaves the poller dumb.

Important files

Discussion points

gastonfournier
gastonfournier approved these changes Nov 21, 2023
View reviewed changes
Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, making sure there's no active poller or metrics

@kwasniew kwasniew changed the title Force stop before start fix: Force stop before start Nov 21, 2023
@kwasniew kwasniew merged commit e9087a1 into main Nov 21, 2023
2 checks passed
@kwasniew kwasniew deleted the force-stop-before-start branch November 21, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwasniew @gastonfournier