Merge pull request #49 from Unleash/fix-payload-stringify

fix: payload stringify in bootstrap

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.5.3
+
+* Fix: payload stringify in bootstrap
+
 ## 1.5.2
 
 * Chore: update dependency range on shared_preferences and uuid

README.md

@@ -193,10 +193,13 @@ final unleash = UnleashClient(
 * If `bootstrapOverride` is `true` (by default), any local cached data will be overridden with the bootstrap specified.   
 * If `bootstrapOverride` is `false` any local cached data will not be overridden unless the local cache is empty.
 
-## Useful commands for development
 
-* run tests: `flutter test`
-* format code: `dart format lib test`
-* analyse code: `flutter analyze lib test`
-* run example app (from inside the `example` dir): `flutter run`
-* publish new version (update manually first depending on semver): `dart pub publish`
+## Release guide
+* Run tests: `flutter test`
+* Format code: `dart format lib test`
+* Analyse code: `flutter analyze lib test`
+* (optional) run example app (from inside the `example` dir): `flutter run`
+* Bump up the version in `pubspec.yaml`
+* Update the `CHANGELOG.md`
+* Create a PR in new branch, merge it to main
+* Publish new version from tip of main: `dart pub publish`

lib/variant.dart

@@ -20,7 +20,7 @@ class Variant {
   }
 
   Map<String, dynamic> toMap() {
-    return {'name': name, 'enabled': enabled, 'payload': payload};
+    return {'name': name, 'enabled': enabled, 'payload': payload?.toMap()};
   }
 
   @override

pubspec.yaml

@@ -3,7 +3,7 @@ description: A Flutter/Dart client that can be used together with the unleash-pr
 homepage: https://github.com/Unleash/unleash_proxy_client_flutter
 repository: https://github.com/Unleash/unleash_proxy_client_flutter
 issue_tracker: https://github.com/Unleash/unleash_proxy_client_flutter
-version: 1.5.2
+version: 1.5.3
 
 environment:
   sdk: ">=2.18.0 <4.0.0"

test/pase_toggles_test.dart → test/parse_toggles_test.dart

@@ -15,7 +15,8 @@ void main() {
       ] 
     }''';
 
-    Map<String, ToggleConfig> result = parseToggles(mockData);
+    Map<String, ToggleConfig> result =
+        parseToggles(stringifyToggles(parseToggles(mockData)));
 
     expect(result.length, 4);
 

test/unleash_proxy_client_flutter_test.dart

@@ -5,6 +5,7 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:http/http.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 import 'package:unleash_proxy_client_flutter/in_memory_storage_provider.dart';
+import 'package:unleash_proxy_client_flutter/payload.dart';
 import 'package:unleash_proxy_client_flutter/shared_preferences_storage_provider.dart';
 import 'package:unleash_proxy_client_flutter/toggle_config.dart';
 import 'package:unleash_proxy_client_flutter/unleash_context.dart';
@@ -1015,7 +1016,10 @@ void main() {
           'flutter-on': ToggleConfig(
               enabled: true,
               impressionData: false,
-              variant: Variant(enabled: true, name: 'variant-name'))
+              variant: Variant(
+                  enabled: true,
+                  name: 'variant-name',
+                  payload: Payload(type: "string", value: "someValue")))
         },
         fetcher: getMock);
 
@@ -1039,7 +1043,7 @@ void main() {
 
     expect(events, ['initialized', 'ready']);
     expect(storageToggles,
-        '{"toggles":[{"name":"flutter-on","enabled":true,"impressionData":false,"variant":{"name":"variant-name","enabled":true,"payload":null}}]}');
+        '{"toggles":[{"name":"flutter-on","enabled":true,"impressionData":false,"variant":{"name":"variant-name","enabled":true,"payload":{"type":"string","value":"someValue"}}}]}');
   });
 
   test('should not emit ready event twice when using bootstrap', () async {