fix: Handle parsing errors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
reviewed
Apr 16, 2024
lib/parse_stringify_toggles.dart
Outdated
| var decoded = jsonDecode(body); | ||
|
|
||
| // Return an empty map if 'toggles' isn't a list or doesn't exist | ||
| if (decoded['toggles'] is! List) { |
There was a problem hiding this comment.
I'd really rather avoid checking for a list here. Stuff should fail and the new catch block should catch that, right? I don't really see a reason this function needs to change, it looks like it's correct, it's getting fed garbage data
There was a problem hiding this comment.
sure makes sense - this was my initial fix, but the try/catch should be enough here agreed
There was a problem hiding this comment.
Nice! I think this looks good, but maybe we keep this open until we understand more about this problem. I'd need to go root around a little in the code
andreas-unleash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch any errors from parsing toggles from storage
Relates to #39