Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5557 - Rename standing agreement files to use full sector name #5558
Fixes #5557 - Rename standing agreement files to use full sector name #5558
Changes from 106 commits
6fbab1ffda1c644560bc07513cf83aefb0bd97ba1450741b43c0b306dac7bdf2c5283fcbbddfb97c2475e95b163ae726cb6d0ab1641d4553e935912480f49ce36a4f98b9d657ed383669d908da5e9571e1866764435a367e45f66df9c49135c68a3d96345a05a1fd057b0133a66d75aadf75138b687f1e7bf43d20db147072add40da26208c98973a2ee955f22bd21ea64fd6da323cfd6552de40c046626cfd1599d47fafb0a104dab8ded1372fa7b3c8528f409a08a82b29cd8d1c2d9627ea97a5452ad7e4ca329ab0bb85c3c55d6f30d1b0a142e6a3dbeced4e0b3c8b71b5670e8366b47940db93d91d572e606970375e6d19c9d7c8630138cc63dd131e58baf06c5cdda7471693b61ebb6a1870762d1d63fee1bbb25b06d570407cf8531d941c8ab461722999129855da1587067c6ea414c734e7f6af3626cd15844132cf95a8762af8e584ca9609e69998df8a3d4a34d59eea08e92a3907d3efd2b3cdd8f462875446cd08cd8ea3fb79671715c253ee85f21db12aFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be COWLY?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TCCOW is good, as this matches TCWEL/TCRED/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't the point of this PR to make thing consistent, I don't see why we wouldn't do this fully consistently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TC COWLY is a TC, while Stafa and Trent aren’t part of TC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COWLY is TC, but STAFA and TNT are PC sectors; for consistency, wouldn't either TCCOW/PCSTA or COWLY/STAFA instead of a mixture of both be preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was my thought. I though we were renaming to full sector names, hence COWLY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or could even be TCCOWLY PCSTAFA to be completely obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to follow that logic to
PCHumberorPCAntrimthough - all of the sector names at Prestwick are proper names of places rather than just fixes/VORs, with the exception of 'South East', which is split into STAFA and TRENT sectors. I don't think we need a 'PC' qualifier before Prestwick sectors because none of the fully split names are duplicated at Swanwick.For London AC sectors, we just have the sector number, because putting 'S' before it would be superfluous. I don't see a need to change this.
Then somehow at some point, we ended up with
TCbefore the sector name for London TC, probably because when we didn't have the sectors fully split out, justNEfor TC Northeast would've looked weird and is confusingly similar to our PC Northeast - and so the convention we've ended up with is havingTCNE,TCRED,TCLAM, etc.For that reason, until such time that we fully split out our TC sectors into their constituent parts, I suggest we continue to use the TC prefix - because
NEorSWon its own is confusing! Eventually we could move to NEDEPS, SWDEPS, OCK, WILLO, TIMBA, but we're not there yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems sensible, and I wouldn't oppose maintaining that status quo, though I don't think keeping "TCNE" and the like is necessarily incompatible with expanding the individual TC sector names.
Also, whilst we're tidying up the file names, might it be an idea to make consistent "Solent"/"SOLENT" and "13+14"/"E (13+14)"?
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.