-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5557 - Rename standing agreement files to use full sector name #5558
Merged
Merged
Changes from 98 commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
6fbab1f
Rename BB_TCCOW.txt to BB_Cowly.txt
aidenbok203 fda1c64
Rename BB_Cowly.txt to BB_TCCOW.txt
aidenbok203 4560bc0
Rename BB_Stafa.txt to BB_TCSTA.txt
aidenbok203 7513cf8
Rename AA_Rat.txt to AA_Rathlin.txt
aidenbok203 3aefb0b
Rename Mor_PB.txt to Moray_PB.txt
aidenbok203 d97ba14
Rename Mor_PE.txt to Moray_PE.txt
aidenbok203 50741b4
Rename Mor_PD.txt to Moray_PD.txt
aidenbok203 3c0b306
Rename PB_Mor.txt to PB_Moray.txt
aidenbok203 dac7bdf
Rename PD_Mor.txt to PD_Moray.txt
aidenbok203 2c5283f
Rename PE_Heb.txt to PE_Hebrides.txt
aidenbok203 cbbddfb
Rename PE_Mor.txt to PE_Moray.txt
aidenbok203 97c2475
Rename Rat_AA.txt to Rathlin_AA.txt
aidenbok203 e95b163
Rename Rat_PK.txt to Rathlin_PK.txt
aidenbok203 ae726cb
Rename Tal_PF.txt to Talla_PF.txt
aidenbok203 6d0ab16
Rename Tal_PH.txt to Talla_PH.txt
aidenbok203 41d4553
Rename Wal_CC.txt to Wallasey_CC.txt
aidenbok203 e935912
Rename Wal_GP.txt to Wallasey_GP.txt
aidenbok203 480f49c
Rename Stafa_BB.txt to TCSTA_BB.txt
aidenbok203 e36a4f9
Rename NS_Ant.txt to NS_Antrim.txt
aidenbok203 8b9d657
Rename Heb_PE.txt to Hebrides_PE.txt
aidenbok203 ed38366
Rename Gal_PK.txt to Galloway_PK.txt
aidenbok203 9d908da
Rename Gal_PF.txt to Galloway_PF.txt
aidenbok203 5e9571e
Rename AA_Hum.txt to AA_Humber.txt
aidenbok203 1866764
Rename Ant_DUBN.txt to Antrim_DUBN.txt
aidenbok203 435a367
Rename Heb_RKE.txt to Hebrides_RKE.txt
aidenbok203 e45f66d
Rename Heb_RKS.txt to Hebrides_RKS.txt
aidenbok203 f9c4913
Rename Hum_AA.txt to Humber_AA.txt
aidenbok203 5c68a3d
Rename Hum_YY-D.txt to Humber_YY-D.txt
aidenbok203 96345a0
Rename Hum_YY-JH.txt to Humber_YY-JH.txt
aidenbok203 5a1fd05
Rename Hum_YY-JL.txt to Humber_YY-JL.txt
aidenbok203 7b0133a
Rename Mor_RKE.txt to Moray_RKE.txt
aidenbok203 66d75aa
Rename Rat_SNE.txt to Rathlin_SNE.txt
aidenbok203 df75138
Rename SNE_Rat.txt to SNE_Rathlin.txt
aidenbok203 b687f1e
Rename YY-D_Hum.txt to YY-D_Humber.txt
aidenbok203 7bf43d2
Rename YY-JH_Hum.txt to YY-JH_Humber.txt
aidenbok203 0db1470
Rename YY-JL_Hum.txt to YY-JL_Humber.txt
aidenbok203 72add40
Rename 10_Hum.txt to 10_Humber.txt
aidenbok203 da26208
Rename 10_Mon.txt to 10_Montrose.txt
aidenbok203 c98973a
Rename 5_Wal.txt to 5_Wallasey.txt
aidenbok203 2ee955f
Rename Ant_Gal.txt to Antrim_Galloway.txt
aidenbok203 22bd21e
Rename Ant_Rat.txt to Antrim_Rathlin.txt
aidenbok203 a64fd6d
Rename Ant_IoM.txt to Antrim_IoM.txt
aidenbok203 a323cfd
Rename Dcs_3.txt to Deancross_3.txt
aidenbok203 6552de4
Rename Dcs_4.txt to Deancross_4.txt
aidenbok203 0c04662
Rename Dcs_Gal.txt to Deancross_Galloway.txt
aidenbok203 6cfd159
Rename Dcs_WC-Tay.txt to Deancross_WC-Tay.txt
aidenbok203 9d47faf
Rename Dcs_S29.txt to Deancross_S29.txt
aidenbok203 b0a104d
Rename Dcs_Tay.txt to Deancross_Tay.txt
aidenbok203 ab8ded1
Rename Dcs_Tal.txt to Deancross_Talla.txt
aidenbok203 372fa7b
Rename East_Mon.txt to East_Montrose.txt
aidenbok203 3c8528f
Rename Gal_Ant.txt to Galloway_Antrim.txt
aidenbok203 409a08a
Rename Gal_Dcs.txt to Galloway_Deancross.txt
aidenbok203 82b29cd
Rename Gal_Tal.txt to Galloway_Talla.txt
aidenbok203 8d1c2d9
Rename Gal_North.txt to Galloway_North.txt
aidenbok203 627ea97
Rename Heb_Tay.txt to Hebrides_Tay.txt
aidenbok203 a5452ad
Rename Hum_10.txt to Humber_10.txt
aidenbok203 7e4ca32
Rename IoM_Rat.txt to IoM_Rathlin.txt
aidenbok203 9ab0bb8
Rename IoM_Wal.txt to IoM_Wallasey.txt
aidenbok203 5c3c55d
Rename Mon_East.txt to Montrose_East.txt
aidenbok203 6f30d1b
Rename Mor_Tay.txt to Moray_Tay.txt
aidenbok203 0a142e6
Rename Mon_Talla.txt to Montrose_Talla.txt
aidenbok203 a3dbece
Rename Mon_Tay.txt to Montrose_Tay.txt
aidenbok203 d4e0b3c
Rename North_Tal.txt to North_Talla.txt
aidenbok203 8b71b56
Rename Rat_7.txt to Rathlin_7.txt
aidenbok203 70e8366
Rename Rat_Ant.txt to Rathlin_Antrim.txt
aidenbok203 b47940d
Rename Rat_IoM.txt to Rathlin_IoM.txt
aidenbok203 b93d91d
Rename S29_Dcs.txt to S29_Deancross.txt
aidenbok203 572e606
Rename S29_Stafa.txt to S29_TCSTA.txt
aidenbok203 970375e
Rename Stafa_27.txt to TCSTA_27.txt
aidenbok203 6d19c9d
Rename Tal_Gal.txt to Talla_Galloway.txt
aidenbok203 7c86301
Rename Stafa_S29.txt to TCSTA_S29.txt
aidenbok203 38cc63d
Rename Stafa_Trent.txt to TCSTA_Trent.txt
aidenbok203 d131e58
Rename Stafa_Wal.txt to TCSTA_Wal.txt
aidenbok203 baf06c5
Rename Talla_Dcs.txt to Talla_Deancross.txt
aidenbok203 cdda747
Rename Talla_Mon.txt to Talla_Montrose.txt
aidenbok203 1693b61
Rename Tay_Dcs.txt to Tay_Deancross.txt
aidenbok203 ebb6a18
Rename Tay_Mon.txt to Tay_Montrose.txt
aidenbok203 70762d1
Rename Trent_Stafa.txt to Trent_TCSTA.txt
aidenbok203 d63fee1
Rename Wal_5.txt to Wallasey_5.txt
aidenbok203 bbb25b0
Rename Wal_North.txt to Wallasey_North.txt
aidenbok203 6d57040
Rename Wal_Stafa.txt to Wallasey_TCSTA.txt
aidenbok203 7cf8531
Rename Wal_IoM.txt to Wallasey_IoM.txt
aidenbok203 d941c8a
Rename TCSTA_Wal.txt to TCSTA_Wallasey.txt
aidenbok203 b461722
Update CHANGELOG.md
aidenbok203 9991298
Rename Ant_AA.txt to Antrim_AA.txt
aidenbok203 55da158
Rename Ant_NS.txt to Antrim_NS.txt
aidenbok203 7067c6e
Rename Ant_PK.txt to Antrim_PK.txt
aidenbok203 a414c73
Rename DUBN_Ant.txt to DUBN_Antrim.txt
aidenbok203 4e7f6af
Rename Cen_PF.txt to Central_PF.txt
aidenbok203 3626cd1
Rename BB_TCSTA.txt to BB_Stafa.txt
aidenbok203 5844132
Rename TCSTA_BB.txt to Stafa_BB.txt
aidenbok203 cf95a87
Rename S29_TCSTA.txt to S29_Stafa.txt
aidenbok203 62af8e5
Rename TCSTA_27.txt to Stafa_27.txt
aidenbok203 84ca960
Rename TCSTA_S29.txt to Stafa_S29.txt
aidenbok203 9e69998
Rename TCSTA_Trent.txt to Stafa_Trent.txt
aidenbok203 df8a3d4
Rename TCSTA_Wallasey.txt to Stafa_Wallasey.txt
aidenbok203 a34d59e
Rename Trent_TCSTA.txt to Trent_Stafa.txt
aidenbok203 ea08e92
Rename Wallasey_TCSTA.txt to Wallasey_Stafa.txt
aidenbok203 a3907d3
Rename PE_WC-Tay.txt to PE_Westcoast-Tay.txt
aidenbok203 efd2b3c
Rename WC-Tay_PE.txt to Westcoast-Tay_PE.txt
aidenbok203 dd8f462
Rename WC-Tay_PF.txt to Westcoast-Tay_PF.txt
aidenbok203 875446c
Rename Deancross_WC-Tay.txt to Deancross_Westcoast-Tay.txt
aidenbok203 d08cd8e
Merge branch 'main' into renaming
aidenbok203 a3fb796
Merge branch 'main' into renaming
aidenbok203 71715c2
Merge remote-tracking branch 'upstream/main' into pr/5558
PLM1995 53ee85f
Update Talla_PF
PLM1995 21db12a
Update .github/CHANGELOG.md
PLM1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:*:*:LANAK:EGPF:*:Galloway:PFAPP:*:8000:LANAK |
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Agreements/Airport/Mor_PD.txt → Agreements/Airport/Moray_PD.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
COPX:*:*:PETOX:EGPD:*:Moray Low:PDAPP:*:12000:ADN | ||
COPX:*:*:DENOG:EGPD:*:Moray Low:PDAPP:*:12000:ADN | ||
COPX:*:*:NANEV:EGPD:*:Moray Low:PDAPP:*:9000:ADN | ||
COPX:*:*:NANEV:EGPD:*:Moray Low:PDAPP:*:9000:ADN |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:*:*:CHINN:EGPE:*:Moray Low:PEAPP:*:12000:CHINN |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Agreements/Airport/PD_Mor.txt → Agreements/Airport/PD_Moray.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
COPX:EGPD:*:PETOX:*:*:PDAPP:Moray Low:*:11000:^ADN | ||
COPX:EGPD:*:DENOG:*:*:PDAPP:Moray Low:*:11000:^ADN | ||
COPX:EGPD:*:NANEV:*:*:PDAPP:Moray Low:*:8000:^ADN | ||
COPX:EGPD:*:NANEV:*:*:PDAPP:Moray Low:*:8000:^ADN |
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:EGPE:*:BONBY:*:*:PEAPP:Moray Low:11000:*:^N560 |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
COPX:*:*:CHASE:EGBB:*:Stafa:BBAPP:*:9000:CHASE | ||
COPX:*:*:CHASE:EGBE:*:Stafa:BBAPP:*:9000:CHASE | ||
COPX:*:*:CHASE:EGBE:*:Stafa:BBAPP:*:9000:CHASE |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:*:*:LANAK:*:*:Talla:PFAPP:*:8000:LANAK |
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Airport/Wal_GP.txt → Agreements/Airport/Wallasey_GP.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
COPX:*:*:TIPOD:EGGP:*:Wallasey:GPAPP:*:6000:MSL | ||
|
||
COPX:*:*:KEGUN:EGGP:*:Wallasey:GPAPP:*:6000:MSL | ||
COPX:*:*:KEGUN:EGGP:*:Wallasey:GPAPP:*:6000:MSL |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Dcs_4.txt → Agreements/Internal/Deancross_4.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
COPX:EGPH:*:LAKEY:*:*:Deancross:London S4:35000:*:LAKEY | ||
COPX:EGPF:*:LAKEY:*:*:Deancross:London S4:35000:*:LAKEY | ||
COPX:EGPH:*:SUBUK:*:*:Deancross:London S4:35000:*:SUBUK | ||
COPX:EGPF:*:SUBUK:*:*:Deancross:London S4:35000:*:SUBUK | ||
COPX:EGPF:*:SUBUK:*:*:Deancross:London S4:35000:*:SUBUK |
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Dcs_S29.txt → Agreements/Internal/Deancross_S29.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
COPX:*:*:LAKEY:EGBB:*:Deancross:Sector 29:*:27000:|LAKEY | ||
COPX:*:*:LAKEY:EGNX:*:Deancross:Sector 29:*:27000:|LAKEY | ||
COPX:*:*:LAKEY:EGBE:*:Deancross:Sector 29:*:27000:|LAKEY | ||
COPX:*:*:LAKEY:EGNJ:*:Deancross:Sector 29:*:27000:|LAKEY | ||
COPX:*:*:LAKEY:EGNJ:*:Deancross:Sector 29:*:27000:|LAKEY |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:*:*:GRICE:EGPD:*:Deancross:Tay:*:26000:GRICE |
hazzas-99 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
COPX:*:*:FOYLE:EGPE:*:Deancross:Westcoast (Tay):*:26000:FOYLE |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Gal_Tal.txt → Agreements/Internal/Galloway_Talla.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
COPX:GIRVA:*:*:EGPH:*:Galloway:Talla:*:17000:|TLA | ||
COPX:TUNSO:*:*:EGPH:*:Galloway:Talla:*:17000:|TLA | ||
|
||
COPX:EGPF:*:TLA:*:*:Galloway:Talla:19000:*:TLA10 | ||
COPX:EGPF:*:TLA:*:*:Galloway:Talla:19000:*:TLA10 |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Mon_Tay.txt → Agreements/Internal/Montrose_Tay.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
COPX:*:*:FINDO:EGPD:*:Montrose:Tay:*:26000:FINDO15 | ||
COPX:*:*:FINDO:EGPE:*:Montrose:Tay:*:26000:FINDO15 | ||
COPX:*:*:NEXUS:EGPD:*:Montrose:Tay:*:26000:|NEXUS | ||
COPX:*:*:NEXUS:EGPD:*:Montrose:Tay:*:26000:|NEXUS |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Stafa_Wal.txt → Agreements/Internal/Stafa_Wallasey.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
COPX:*:*:NANTI:EGGP:*:Stafa:Wallasey:*:10000:NANTI | ||
COPX:*:*:NANTI:EGNR:*:Stafa:Wallasey:*:10000:NANTI | ||
COPX:*:*:NANTI:EGNR:*:Stafa:Wallasey:*:10000:NANTI |
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Tal_Gal.txt → Agreements/Internal/Talla_Galloway.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
COPX:*:*:ENIPI:EGPK:*:Talla:Galloway:*:20000:ENIPI | ||
|
||
COPX:EGPH:*:*:TRN:*:Talla:Galloway:12000:*:^P600 | ||
COPX:EGPH:*:*:DCS:*:Talla:Galloway:12000:*:^N864 | ||
COPX:EGPH:*:*:DCS:*:Talla:Galloway:12000:*:^N864 |
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
Agreements/Internal/Tay_Dcs.txt → Agreements/Internal/Tay_Deancross.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
COPX:EGPD:*:GRICE:*:*:Tay:Deancross:25000:*:^GRICE | ||
COPX:EGPE:*:GOW:*:*:Tay:Deancross:25000:*:GOW | ||
COPX:EGPE:*:GOW:*:*:Tay:Deancross:25000:*:GOW |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be COWLY?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TCCOW is good, as this matches TCWEL/TCRED/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't the point of this PR to make thing consistent, I don't see why we wouldn't do this fully consistently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TC COWLY is a TC, while Stafa and Trent aren’t part of TC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COWLY is TC, but STAFA and TNT are PC sectors; for consistency, wouldn't either TCCOW/PCSTA or COWLY/STAFA instead of a mixture of both be preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was my thought. I though we were renaming to full sector names, hence COWLY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or could even be TCCOWLY PCSTAFA to be completely obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to follow that logic to
PCHumber
orPCAntrim
though - all of the sector names at Prestwick are proper names of places rather than just fixes/VORs, with the exception of 'South East', which is split into STAFA and TRENT sectors. I don't think we need a 'PC' qualifier before Prestwick sectors because none of the fully split names are duplicated at Swanwick.For London AC sectors, we just have the sector number, because putting 'S' before it would be superfluous. I don't see a need to change this.
Then somehow at some point, we ended up with
TC
before the sector name for London TC, probably because when we didn't have the sectors fully split out, justNE
for TC Northeast would've looked weird and is confusingly similar to our PC Northeast - and so the convention we've ended up with is havingTCNE
,TCRED
,TCLAM
, etc.For that reason, until such time that we fully split out our TC sectors into their constituent parts, I suggest we continue to use the TC prefix - because
NE
orSW
on its own is confusing! Eventually we could move to NEDEPS, SWDEPS, OCK, WILLO, TIMBA, but we're not there yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems sensible, and I wouldn't oppose maintaining that status quo, though I don't think keeping "TCNE" and the like is necessarily incompatible with expanding the individual TC sector names.
Also, whilst we're tidying up the file names, might it be an idea to make consistent "Solent"/"SOLENT" and "13+14"/"E (13+14)"?