TECH-232: Add support for VATSIM.net Webhooks #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrokman
reviewed
Jan 13, 2025
| foreach (request()->json('actions') as $action) { | ||
| $class = config("services.vatsim-net.webhook.jobs.{$action['action']}"); | ||
| if ($class && class_exists($class)) { | ||
| dispatch(new $class(request()->json('resource'), $action))->afterResponse(); |
There was a problem hiding this comment.
for ease of running sync locally here can we just drop ->afterResponse() entirely. Dispatching queue jobs should be fast anyway and I don't think the system sending the webhooks is gonna mind too much
Suggested change
| dispatch(new $class(request()->json('resource'), $action))->afterResponse(); | |
| dispatch(new $class(request()->json('resource'), $action)); |
There was a problem hiding this comment.
->defer() actually handles the sync driver proper and waits until after the response is returned too. So probably best of both worlds to do that.
maxbrokman
reviewed
Jan 13, 2025
| } | ||
|
|
||
| foreach (request()->json('actions') as $action) { | ||
| $class = config("services.vatsim-net.webhook.jobs.{$action['action']}"); |
There was a problem hiding this comment.
this is very laravel, but personally I'd have an explicit switch here with some logging for actions we don't understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://vatsim.dev/services/webhooks.
If testing locally on
sync, be sure to remove->afterResponse().