do not initialize StringLibContext's static buffers #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the performance of the HelloWorld benchmark for K2 by a factor of 32. Previously, we used zero-initialized
std::array
as a buffer inStringLibContext
. This zeroing of the 8MB array at the start of each request consumed significant CPU time. By switching to uninitializedstd::array
, we avoid unnecessary initialization, resulting in substantial performance improvements.Following benchmark is enough to see the difference: