wlserver: wlserver_run(): ensure waylock is released when wl_event_lo… #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op_dispatch returns ret<0
|
Edit: it appears that this PR does not fix that hang, and the hang matt reported that still occurred w/ pr #1335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…op_dispatch returns ret<0
@matte-schwartz reported that they found another bug w/ gamescope hanging, which wasn’t fixed by #1335
When looking at matt’s backtrace for wlserver, it appeared to be stuck waiting on mutex
g_SteamCompMgrXWaylandServerMutexThis makes me think that said hang is due to a deadlock w/ the mutexes
g_SteamCompMgrXWaylandServerMutexandwaylockWhich hopefully will be fixed by this PR which will prevent wlserver from trying to lock
g_SteamCompMgrXWaylandServerMutexwhile having currently lockedwaylock