Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer native versions of various DLLs #266

Open
wants to merge 1 commit into
base: bleeding-edge
Choose a base branch
from

Conversation

Tiagoquix
Copy link

@Tiagoquix Tiagoquix commented Dec 17, 2024

This PR aims to address ValveSoftware/Proton#8308.

A previous issue of mine was already addressed by this commit.

This PR extends the same effects of that commit to all various other DLLs that can be used by https://github.com/ThirteenAG/Ultimate-ASI-Loader/releases/latest (excluding non-existent DLLs under Wine dlls folder such as the Bink ones).

Caveats

This approach, in general, has already been rejected upstream. See the discussion in https://gitlab.winehq.org/wine/wine/-/merge_requests/6527 for more details (specifically, this comment).

From what I understand, upstream plans to enhance the DLL loading mechanism to solve those cases of native vs. built-in. However, for the time being, this should bring a quality-of-life change to gamers that want to add mods to their games.

Please see the aforementioned Proton issues and their comments for more details regarding security risks.

Thanks for your attention.

Edit: to complement, this is the opinion of Paul Gofman, responsible for the "prefer native dinput8.dll" commit in this repository:

my opinion is that these overrides suck, we'd better have a better way to detect but noone came up with it yet. Maybe we can choose something very wide used to add, not sure if that is winhttp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant