Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Server.Enrichment.Hashlookup.yaml #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jCrossM
Copy link

@jCrossM jCrossM commented Apr 15, 2023

Hi,

If you have some VQL tips to optimize this artifact I'm interested.

Thx!

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2023

CLA assistant check
All committers have signed the CLA.

@scudette
Copy link
Collaborator

It's probably not going to be useful in practice because it sends an API call for each file.

You probably need to limit the hashes to check and maybe combine many hashes in the same API call. Do you know if this is a feature of the API?

Another possibility is to look up hashes in multiple threads so they are done in parallel.

@jCrossM
Copy link
Author

jCrossM commented Apr 16, 2023

Yes, wee can send bulk hashes to the API. I will look this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants