Add React eslint & update depencenies #3090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my changes made TypingTweaks cause crashes, honestly so incredible anyway should be fixed now and everything else seems to work fine |
Nuckyz
requested changes
Dec 22, 2024
| @@ -105,7 +107,7 @@ const ErrorBoundary = LazyComponent(() => { | |||
| }; | |||
| }) as | |||
| React.ComponentType<React.PropsWithChildren<Props>> & { | |||
| wrap<T extends object = any>(Component: React.ComponentType<T>, errorBoundaryProps?: Omit<Props<T>, "wrappedProps">): React.FunctionComponent<T>; | |||
| wrap<T extends object = any>(Component: React.ComponentType<T>, errorBoundaryProps?: Omit<Props<T>, "wrappedProps">): (props: T) => ReactElement<any>; | |||
| }; | |||
There was a problem hiding this comment.
Since we are sure this is a FunctionalComponent, we should use the proper type for it
There was a problem hiding this comment.
no because react updated FunctionComponent type, it can now also return Promise<ReactElement> and that causes type errors and is not desired
| const color = p.added ? "lime" : p.removed ? "red" : "grey"; | ||
| return <div style={{ color, userSelect: "text", wordBreak: "break-all", lineBreak: "anywhere" }}>{p.value}</div>; |
There was a problem hiding this comment.
Shouldnt this use something like p.value for the key instead of the index?
| @@ -61,7 +61,7 @@ function withDispatcher(dispatcher: React.Dispatch<React.SetStateAction<boolean> | |||
| title: "Oops!", | |||
| body: ( | |||
| <ErrorCard> | |||
| {err.split("\n").map(line => <div>{Parser.parse(line)}</div>)} | |||
There was a problem hiding this comment.
Same argument as the other, use line for key instead?
| const { width, height } = computeWidthAndHeight(a.width, a.height); | ||
| return ( | ||
| <div> |
| @@ -69,6 +69,7 @@ export function HistoryModal({ modalProps, message }: { modalProps: ModalProps; | |||
|
|
|||
| {timestamps.map((timestamp, index) => ( | |||
| <TabBar.Item | |||
| key={index} | |||
There was a problem hiding this comment.
Since there are a lot of index usage for keys i'll leave a warning in each to be sure they get changed, if we go that way
| @@ -113,6 +113,7 @@ function RolesAndUsersPermissionsComponent({ permissions, guild, modalProps, hea | |||
|
|
|||
| return ( | |||
| <div | |||
| key={index} | |||
| @@ -159,7 +159,7 @@ export default LazyComponent(() => { | |||
| onClick={() => openBlockModal()} | |||
| /> | |||
| )} | |||
| {review.sender.badges.map(badge => <ReviewBadge {...badge} />)} | |||
| {review.sender.badges.map((badge, idx) => <ReviewBadge key={idx} {...badge} />)} | |||
| lines = hljsHtml | ||
| .split("\n") | ||
| .map((line, i) => <span key={i} dangerouslySetInnerHTML={{ __html: line }} />); | ||
| } catch { | ||
| lines = content.split("\n").map(line => <span>{line}</span>); | ||
| lines = content.split("\n").map((line, idx) => <span key={idx}>{line}</span>); |
| // [Cynthia] this makes it so when you highlight the codeblock | ||
| // empty lines are also selected and copied when you Ctrl+C. | ||
| if (line.length === 0) { | ||
| return <span>{"\n"}</span>; | ||
| return <span key={idx}>{"\n"}</span>; |
| {lines.map(line => ( | ||
| <span>{line}</span> | ||
| {lines.map((line, idx) => ( | ||
| <span key={idx}>{line}</span> |
Nuckyz
requested changes
Dec 22, 2024
| @@ -47,7 +47,7 @@ export interface ModalOptions { | |||
| onCloseCallback?: (() => void); | |||
| } | |||
|
|
|||
| type RenderFunction = (props: ModalProps) => ReactNode; | |||
| type RenderFunction = (props: ModalProps) => ReactElement<any>; | |||
There was a problem hiding this comment.
Why does it need to be ReactElement exactly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what it says in the title
I also was in the process of adding eslint-react-hooks but I realised it sucks ass for a multitude of reasons so I aborted adding that. there are a few hook changes from that nevertheless
Before merging, everywhere where a component key was added or a hook usage was changed needs testing