Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix built-in rules: don't wrap directive values in double quotes if not necessary #3414

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix built-in rules: don't wrap directive values in double quotes if not necessary #3414

merged 1 commit into from
Jan 13, 2025

Conversation

Gedochao
Copy link
Contributor

Fixes #3052

tgodzik
tgodzik requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are still failing

@Gedochao
Copy link
Contributor Author

Looks like some tests are still failing

@tgodzik the failures seem unrelated to this PR, and seem to be caused by Scala Native not supporting Scala 2.13.16 at the time the CI was being run.
Restarted the CI.

@Gedochao Gedochao force-pushed the maintenance/fix-dont-wrap-values-in-quotes branch from c3bab7c to cdcf91c Compare January 13, 2025 09:04
@Gedochao
Copy link
Contributor Author

Rebased & added a retry on the CI for a test using Scala Native (it seems there may have been an intermittent timeout there for one test)

@Gedochao Gedochao force-pushed the maintenance/fix-dont-wrap-values-in-quotes branch from cdcf91c to a648a09 Compare January 13, 2025 10:48
@Gedochao
Copy link
Contributor Author

Adjusted the using directives with boolean values are handled correctly test to check a different boolean directive (//> using python)

@Gedochao Gedochao force-pushed the maintenance/fix-dont-wrap-values-in-quotes branch from a648a09 to d7e37c2 Compare January 13, 2025 11:51
@Gedochao Gedochao force-pushed the maintenance/fix-dont-wrap-values-in-quotes branch from d7e37c2 to 46ae7c7 Compare January 13, 2025 13:51
@Gedochao Gedochao enabled auto-merge (squash) January 13, 2025 15:09
@Gedochao Gedochao merged commit da025a0 into VirtusLab:main Jan 13, 2025
50 checks passed
@Gedochao Gedochao mentioned this pull request Jan 16, 2025
Open
@Gedochao Gedochao deleted the maintenance/fix-dont-wrap-values-in-quotes branch January 16, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@kasiaMarek kasiaMarek Awaiting requested review from kasiaMarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--fix Command Boolean Handling
2 participants
@Gedochao @tgodzik