fix: Should reset selected version if runrime change

Voxelum · Dec 28, 2023 · 4680f2d · 4680f2d
1 parent 9c8d116
commit 4680f2d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/xmcl-keystone-ui/src/util/instanceModLoaderDefault.ts b/xmcl-keystone-ui/src/util/instanceModLoaderDefault.ts
@@ -21,6 +21,7 @@ export function useInstanceModLoaderDefault(path: Ref<string>, runtime: Ref<Runt
               ...runtime.value,
               fabricLoader: version.version,
             },
+            version: '',
           })
           return true
         }
@@ -35,6 +36,7 @@ export function useInstanceModLoaderDefault(path: Ref<string>, runtime: Ref<Runt
               ...runtime.value,
               quiltLoader: version.version,
             },
+            version: '',
           })
           return true
         }
@@ -48,6 +50,7 @@ export function useInstanceModLoaderDefault(path: Ref<string>, runtime: Ref<Runt
               ...runtime.value,
               forge: version.version,
             },
+            version: '',
           })
           return true
         }
@@ -61,6 +64,7 @@ export function useInstanceModLoaderDefault(path: Ref<string>, runtime: Ref<Runt
               ...runtime.value,
               neoForged: version,
             },
+            version: '',
           })
           return true
         }

diff --git a/xmcl-runtime/instance/InstanceService.ts b/xmcl-runtime/instance/InstanceService.ts
@@ -456,6 +456,11 @@ export class InstanceService extends StatefulService<InstanceState> implements I
       }
     }
 
+    if (result.runtime && state.version && typeof result.version === 'undefined') {
+      // Reset the version if the runtime is changed
+      result.version = ''
+    }
+
     if ('server' in options) {
       if (options.server) {
         if (options.server.host !== state.server?.host || options.server.port !== state.server.port) {