-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explainer changes for how currency-related things work #571
Conversation
8d31e25
to
2f99bec
Compare
Question regarding this point: Why can't the seller receive the exact bid in its original currency in Can we change this behavior to allow |
Thanks for the feedback; that's a good point (though beware of rounding rules!); I am working on changing it (well, almost ready to mail to the -code- CL), but one bit of warning: the behavior will be different between M114/115 and 116+. |
Hey @trentunderwood Please do note that the values passed into the reporting functions are rounded, so that they only have 8 bits of mantissa. Please see #486. The work going on here is about currency; the rounding of bid values for privacy reasons is separate. |
Thank you!
Do you mean that you are changing the bid passed to |
Yep. See https://chromium-review.googlesource.com/c/chromium/src/+/4573913 as well as changes to this pull request. |
That sounds great - thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still somewhat confused, so I added some clarification rewordings and asked some verifying questions to make sure I'm understanding this properly.
Co-authored-by: Paul Jensen <[email protected]>
SHA: c6491c4 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.