cleaning up unnecessary methods

build.gradle

@@ -24,6 +24,8 @@ dependencies {
 
     testImplementation 'org.junit.jupiter:junit-jupiter:5.5.1'
     testImplementation 'org.hamcrest:hamcrest-library:2.1'
+    testImplementation "org.mockito:mockito-junit-jupiter:3.2.4"
+
 }
 
 test {

src/main/java/eu/dev089/components/RequestCreator.java

@@ -8,15 +8,19 @@
 public class RequestCreator {
 
     private static final String URL = "https://www.bienenkorb-shop.de/index.php/rest/V1/";
+    private final String token;
 
-    private Request.Builder requestBuilder(String contextPath) {
-        var bk_token = System.getenv().get("BK_TOKEN");
-        if (bk_token == null || bk_token.isEmpty()) {
+    public RequestCreator(String token) {
+        if (token == null || token.isEmpty()) {
             throw new IllegalArgumentException("please provide a bearer token via ENV");
         }
+        this.token = token;
+    }
+
+    Request.Builder requestBuilder(String contextPath) {
         return new Request.Builder()
                 .url(URL + contextPath)
-                .addHeader("Authorization", String.format("Bearer %s", bk_token))
+                .addHeader("Authorization", String.format("Bearer %s", token))
                 .addHeader("Cache-Control", "no-cache")
                 .addHeader("Connection", "keep-alive");
     }

src/main/java/eu/dev089/components/Updater.java

@@ -27,8 +27,7 @@ public class Updater extends TimerTask {
     private OkHttpClient client;
 
     public Updater() {
-        this.creator = new RequestCreator();
-
+        this.creator = new RequestCreator(System.getenv().get("BK_TOKEN"));
     }
 
     @Override

src/test/java/eu/dev089/components/RequestCreatorTest.java

@@ -0,0 +1,62 @@
+package eu.dev089.components;
+
+import static eu.dev089.FeatureMatcher.createFeatureMatcher;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.hasItem;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.notNullValue;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import java.util.stream.Stream;
+import okhttp3.Request;
+import okhttp3.Request.Builder;
+import org.hamcrest.Matcher;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+class RequestCreatorTest {
+
+    @Test
+    void setsBearerToken() {
+        var token = "THIS_IS_MY_TOKEN";
+        var creator = new RequestCreator(token);
+        var request = creator.requestBuilder("somePath").get().build();
+
+        assertThat(request, hasToken(token));
+    }
+
+    private static Matcher<Request> hasToken(String token) {
+        return createFeatureMatcher(hasItem("Bearer " + token), "token",
+                r -> r.headers().values("Authorization"));
+    }
+
+    @ParameterizedTest
+    @MethodSource("emptyTokens")
+    void reportsNoTokenSet(String token) {
+        assertThrows(IllegalArgumentException.class, () -> {
+            new RequestCreator(token);
+        });
+    }
+
+    static Stream<String> emptyTokens() {
+        return Stream.of(null, "");
+    }
+
+    @ParameterizedTest
+    @MethodSource("headers")
+    void setsHeaders(String header) {
+        var creator = new RequestCreator("token");
+        var builder = creator.requestBuilder("context");
+
+        assertThat(builder, hasHeaderProperty(header));
+    }
+
+    private static Matcher<Request.Builder> hasHeaderProperty(String header) {
+        return createFeatureMatcher(is(notNullValue()), "token", r -> r.build().headers().values(header));
+    }
+
+    static Stream<String> headers() {
+        return Stream.of("Authorization", "Cache-Control", "Connection");
+    }
+}

src/test/java/eu/dev089/components/UpdaterTest.java

@@ -12,7 +12,7 @@
 class UpdaterTest {
 
     private Updater updater = new Updater();
-    private RequestCreator creator = new RequestCreator();
+    private RequestCreator creator = new RequestCreator(System.getenv().get("BK_TOKEN"));
 
 
     void run() {