Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove redundant templates under /db/my/* #663

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benjamin-antupit
Copy link
Collaborator

No description provided.

Adds an edit button (and page) to the event detail mega page. Edit page shows all user hour instances for event and allow editor to add additional instances or delete instance(s).
Fix `CC Report` button to edit their report, create a report if none exists, or link to existing reports if the event has been closed.

clean: imports and remove unused templates
@benjamin-antupit benjamin-antupit self-assigned this Jun 4, 2022
@benjamin-antupit benjamin-antupit added this to the Summer 2022 milestone Jun 4, 2022
@tnurse18
Copy link
Member

tnurse18 commented Jun 4, 2022

I would be careful about removing views here and test this throughly. If I remember correctly, certain users may see a "/db/my" page when LNL members would be seeing a "/db/events" page. Merging these in with similar views may be a good idea, but be mindful of how this may impact old events and double check that all the existing links / permissions to the views you change are updated. There are links to these pages all over the place.

@benjamin-antupit
Copy link
Collaborator Author

Agreed, @tnurse18. My current thought is to keep /my/events/, /my/events/<id>/survey/, and /my/events/survey/success/. I know this will be quite a project, so I'm thinking I'll chip away at it over time and not rush to merge anything.

I'd like to replace /my/events/<id>/report with a redirect to CC report edit/creation for the logged-in user in the event module. The same URL probably will still exist, but it'll just be a redirect.

@Muirrum Muirrum changed the title Remove redundant templates under /db/my/* [WIP] Remove redundant templates under /db/my/* Jun 6, 2022
@benjamin-antupit benjamin-antupit marked this pull request as draft September 18, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants