fix: remove cchardet as a dependency #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cchardet` hasn't had a commit in almost two years (8 days shy as of this commit). [This issue](PyYoshi/cChardet#81) is a six month old bug showing that `cchardet` doesn't support python 3.11, which is the most recent python. `cchardet` is fast, certainly, though the usage here is not as performance sensitive as would warrant its use over `chardet`, e.g. a difference of 800ms is probably not something that is worth keeping problematic dependencies around.
rockstar
force-pushed
the
fix/no-more-cchardet
branch
from
0b142e2 to
3fc53cc
Compare
davidstanley01
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cchardethasn't had a commit in almost two years (8 days shy as of this commit). This issue is a six month old bug showing thatcchardetdoesn't support python 3.11, which is the most recent python.cchardetis fast, certainly, though the usage here is not as performance sensitive as would warrant its use overchardet, e.g. a difference of 800ms is probably not something that is worth keeping problematic dependencies around.