Fixes 'URI formats are not supported' error thrown by GetDirectoryName #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetDirectoryNamefunction inGetPhysicalSiteRootPathkept throwing an error saying "URI formats are not supported". First stripping the execution path of itsfile:///prefix, before passing it to theGetDirectoryNamemethod, seems to fix this.Also, this path was first stored in a variable, but afterwards in the
foreachloop, it was retrieved again, thepathvariable is hence not used. Not sure if that is intentional ? I now use the variable inside theforeachloop.Finally, I added automatic Nuget package restore in the solution, not sure if that was allowed or not.