Fixing Namespace Option Ending with Backslash in LiftMigration Command #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadJacky
force-pushed
the
bugfix/fix-namespace-concatenation-with-duplicate-slash
branch
from
8257ef0 to
17f8dba
Compare
BadJacky
force-pushed
the
bugfix/fix-namespace-concatenation-with-duplicate-slash
branch
from
17f8dba to
2e593f2
Compare
WendellAdriel
approved these changes
May 28, 2024
BadJacky
deleted the
bugfix/fix-namespace-concatenation-with-duplicate-slash
branch
mickverm
pushed a commit
to mickverm/laravel-lift
that referenced
this pull request
Sep 12, 2024
…e-concatenation-with-duplicate-slash Fixing Namespace Option Ending with Backslash in LiftMigration Command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the
LiftMigrationcommand where the namespace option could end with a backslash (\\). In the original code, if the namespace option ended with a backslash, it would result in two consecutive backslashes when concatenating the model name. This could lead to unexpected issues.In this PR, I've used the
rtrimfunction to ensure that the namespace option does not end with a backslash before concatenating the model name.Here's the modified line of code:
This change has passed all tests, including a new test case specifically designed to check if a migration file is correctly generated when the namespace option ends with two backslashes (
\\).Please review this PR and feel free to provide any feedback or suggestions.