Allow some warnings when building libgcc #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhex
force-pushed
the
rebase-upstream
branch
from
561e36f to
f77a0fb
Compare
vejbomar
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for the fix!
My only concern is that we'll never remove -Wno-error=unused-parameter -Wno-error=missing-prototypes -Wno-error=unused-function even if upstream will fix them. Imo creating a mechanism that will remind us e.g. by failing pipeline if these are not needed anymore is too complicated for a little benefit. What about at least creating an issue for that?
Blackhex
force-pushed
the
rebase-upstream
branch
8 times, most recently
from
7033fb0 to
645fe76
Compare
Blackhex
force-pushed
the
rebase-upstream
branch
2 times, most recently
from
be82394 to
90ef413
Compare
Blackhex
force-pushed
the
libgcc-allow-warnings
branch
from
a1ad6dc to
f26aa22
Compare
eukarpov
approved these changes
Nov 1, 2024
Blackhex
force-pushed
the
rebase-upstream
branch
3 times, most recently
from
a83b9a4 to
cbc273b
Compare
Blackhex
force-pushed
the
libgcc-allow-warnings
branch
from
f26aa22 to
45afdd2
Compare
eukarpov
pushed a commit
that referenced
this pull request
Nov 11, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 11, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 11, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 12, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 13, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 13, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 14, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 15, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 25, 2024
eukarpov
pushed a commit
that referenced
this pull request
Nov 25, 2024
Blackhex
added a commit
that referenced
this pull request
Nov 28, 2024
Blackhex
added a commit
that referenced
this pull request
Nov 28, 2024
Blackhex
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent GCC commit 71c7b44 added
-Werrorwhen building libgcc. This PR allows some warnings to pass the build. I suppose most of them will be fixed upstream soon except of Windows-on-ARM-Experiments/mingw-woarm64-build#216.Tested by https://github.com/Windows-on-ARM-Experiments/mingw-woarm64-build/actions/runs/11446540006