device: reduce RoutineHandshake allocations #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce allocations by eliminating byte reader, hand-rolled decoding and reusing message structs. Signed-off-by: Alexander Yastrebov <[email protected]>
Comment on lines
+121
to
+124
| func (msg *MessageInitiation) unmarshal(b []byte) error { | ||
| if len(b) < MessageInitiationSize { | ||
| return errMessageTooShort | ||
| } |
There was a problem hiding this comment.
Maybe name it reset.
Also the size of the packet is checked earlier
wireguard-go/device/receive.go
Lines 191 to 204 in 12269c2
so this check could be removed as well as error result check at the callsite.
| @@ -286,17 +290,15 @@ func (device *Device) RoutineHandshake(id int) { | |||
|
|
|||
| // unmarshal packet | |||
|
|
|||
| var reply MessageCookieReply | |||
| reader := bytes.NewReader(elem.packet) | |||
There was a problem hiding this comment.
Here byte reader can be replaced with https://pkg.go.dev/encoding/binary#Decode added in 1.23 golang/go#60023 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce allocations by eliminating byte reader, hand-rolled decoding and reusing message structs.