Desafio-1 #13
Open
Desafio-1 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcilas
reviewed
Dec 20, 2018
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href=""><script src=""></script> | ||
| <title>Womakerscode</title> |
There was a problem hiding this comment.
Coloca o favicon (icon.ico)
|
|
||
| <body> | ||
| <img src="images/logo.png" alt="Logo Womakers Code" width="100px"> | ||
| <ul> |
There was a problem hiding this comment.
Isso é um menu, não apenas uma lista, então sua tag nav com links para as respectivas seções do site.
| <li>Contato</li> | ||
| </ul> | ||
|
|
||
| <div class="welcome"> |
There was a problem hiding this comment.
É mais semântico usar a tag section para demarcar as seções
https://www.w3schools.com/tags/tag_section.asp
Suggested change
| <div class="welcome"> | |
| <section id="home" class="welcome"> |
| <div class="welcome"> | ||
| <h1>Bem vind@</h1> | ||
| <h2>Curabitur Iaculis</h2> | ||
| <h5>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras consequat ultricies facilisis. Quisque varius tortor eget lacus tincidunt cursus. </h5> |
There was a problem hiding this comment.
É uma boa prática respeitar a hierarquia dos Headings h1, h2, h3..., não usar só por causa do tamanho da fonte, pois isso depois será mudado na aplicação de estilos
|
|
||
|
|
||
| </div> | ||
| <div class="quem-eu"> |
There was a problem hiding this comment.
Seria legal já customizar os textos, foto, contatos e redes sociais com suas informações, afinal esse será seu portfólio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.