Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Css #30

wants to merge 2 commits into from

Conversation

NayaraCN
Copy link

@NayaraCN NayaraCN commented Aug 3, 2019

Desafio Parte 2: meu css.

<title>Portifólio - MySite</title>
<!-- <meta charset="utf-8"/> -->

<meta name="author" content="Nayara">
Copy link

@happymoon happymoon Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nayara, essas tags precisam ser fechadas, pra isso basta colocar barra no final, exemplo:
<meta name="application-name" content="Desenvolvimento Profissional" />


<main>
<!--<div class="teste"></div>-->
<div id="home">
Copy link

@happymoon happymoon Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nesse caso aqui, não tem muito sentido você utilizar tanto o <div> quanto o <section>, você pode usar só o

se quiser manter essa questão semântica

<div id="email"><a href="mailto:[email protected]">[email protected]</a></div>

<div id="phone">
<a href="tel:+5522999999999">+55 22 999999999</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show de bola usar o "tel:" aqui :)

Copy link

@happymoon happymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oi Nayara, parabéns! Seu código está bem estruturado e limpo. Alteraria umas coisinhas aqui e alí, mas são apenas abordagens diferentes de se fazer a mesma coisa, não tem nada errado, de fato.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants