Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desafio 1 - Estruturação do template com HTML5 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IT-maiara-costa
Copy link

No description provided.

@happymoon happymoon self-requested a review December 12, 2018 17:54
<a href="tel:+5521987654321">+55 21 987654-321</a><br/>
</address>

<h3>Mídias</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aqui vc abriu um título mas não colocou nenhum conteúdo, pretende colocar? Caso não, não precisa do título.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irei por os icons depois


</section>

<br>
Copy link

@happymoon happymoon Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avalia se é realmente necessário o uso de <br>, pois se é apenas para dar uma margem entre os elementos, é recomendável fazer isso utilizando CSS no próximo passo e não gerar uma linha extra com um caractere sem função semântica.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entendi, obrigada

Copy link

@happymoon happymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em geral está bem limpo e organizado seu código Maiara, meus parabéns :)

Atualizando seu repo com os novos desafios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants