Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Content: No need to pass default get_the_content args #37701

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Post Content: No need to pass default get_the_content args #37701

merged 1 commit into from
Jan 4, 2022

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jan 4, 2022

Description

PR is just a minor clean-up for code I missed in #37622. There's no need to pass default arguments to get_the_content.

How has this been tested?

The post content block should work as expected.

Types of changes

Code Quality

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Jan 4, 2022
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner January 4, 2022 05:51
@Mamaduka Mamaduka added [Block] Post Content Affects the Post Content Block [Type] Code Quality Issues or PRs that relate to code quality labels Jan 4, 2022
@Mamaduka
Copy link
Member Author

Mamaduka commented Jan 4, 2022

Thank you, Nik 🦸

@Mamaduka Mamaduka merged commit ca85ced into trunk Jan 4, 2022
@Mamaduka Mamaduka deleted the remove/post-content-default-args branch January 4, 2022 09:01
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@carolinan carolinan Awaiting requested review from carolinan

Assignees

@Mamaduka Mamaduka

Labels
[Block] Post Content Affects the Post Content Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @ntsekouras