fix: Add Image component and CDN src support to Graphic component #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
refs/pull/3062/merge
|
| Run status |
|
| Run duration | 05m 19s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
1006
|
| View all changes introduced in this branch ↗︎ | |
mannycarrera4
changed the title
mannycarrera4
commented
Dec 9, 2024
| **PR:** [#3062](https://github.com/Workday/canvas-kit/pull/3062) | ||
|
|
||
| We've updated `Graphic` and its `src` prop to accept a `string` value to support images loaded from a CDN or SAS. The previous API is still supported. | ||
|
|
There was a problem hiding this comment.
Wanted to add this to the upgrade guide for people moving from v10 to v11
mannycarrera4
commented
Dec 9, 2024
| <h3>Using a Square Image</h3> | ||
| <Avatar as="div" size={200} url="https://placekitten.com/g/450/450" /> | ||
| <Avatar as="div" size={200} url="https://i.imgur.com/himSfZn.jpeg" /> |
There was a problem hiding this comment.
These URLs were broken, so I updated them.
mannycarrera4
commented
Dec 9, 2024
mannycarrera4
added
on hold
|
closing this to rethink about different possibilities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3049
Release Category
Components
Release Note
Imagecomponent has been added to better support raster images or images loaded from a CDN/SAS.Graphiccomponent now support a string via thesrcprop.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)