feat: Refactor Skeleton to use our new styling utilities and new tokens #3088
+247
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
skeleton
|
| Run status |
|
| Run duration | 02m 44s |
| Commit |
|
| Committer | Thu Nguyen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
929
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.15%
|
|
|---|---|
|
Untested elements
|
1534
|
|
Tested elements
|
409
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
mannycarrera4
changed the title
thunguyen19
changed the title
thunguyen19
changed the title
thunguyen19
force-pushed
the
skeleton
branch
3 times, most recently
from
3ee9e6a to
3851b00
Compare
thunguyen19
changed the title
thunguyen19
commented
Jan 14, 2025
| @@ -18,6 +18,9 @@ any questions. | |||
|
|
|||
| - [Codemod](#codemod) | |||
| - [Instructions](#instructions) | |||
| - [Component Updates](#component-updates) | |||
| - [Styling API and CSS Tokens](#styling-api-and-css-tokens) | |||
| - [Avatar](#avatar) | |||
There was a problem hiding this comment.
Ooops copy pasta. Will fix this.
Updated Upgrade guide note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2958
Release Category
Components
Release Note
Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.
BREAKING CHANGES
Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a
prerelease/majorbranch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)