Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update banner image on welcome page #3113

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Jan 28, 2025

Summary

Fixes: #3110
Our old banner was dated, updating our welcome banner for something new and fresh.

Release Category

Documentation


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Jan 28, 2025
Copy link

cypress bot commented Jan 28, 2025

Workday/canvas-kit    Run #8231

Run Properties:  status check passed Passed #8231  •  git commit e1f9a86475 ℹ️: Merge 711dbb17d6d25f4824b851d3b85e2751da11cbdd into e1935d1ae7d2a32a746decd4ab55...
Project Workday/canvas-kit
Branch Review mc-banner-update
Run status status check passed Passed #8231
Run duration 02m 54s
Commit git commit e1f9a86475 ℹ️: Merge 711dbb17d6d25f4824b851d3b85e2751da11cbdd into e1935d1ae7d2a32a746decd4ab55...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 929
View all changes introduced in this branch ↗︎
UI Coverage  21.19%
  Untested elements 1530  
  Tested elements 409  
Accessibility  99.17%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 162  

@alanbsmith alanbsmith merged commit 707596e into Workday:master Jan 28, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ready for review Code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook Homepage Banner
3 participants