Using Combo Event 0 to start trace module for VE2 #8738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
As of now we were generating USER_EVENT_0 in CDO to start the trace module for VE2 which was interfering with two of the profiling metric sets.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
After discussion with @pgschuey and @vipangul we decided to use combo_event_0 which is not being used currently and won't interfere with trace.
Risks (if any) associated the changes in the commit
Changes needs to be done in AIECompiler to start generating COMBO_EVENT_0 in cdo instead of USER_EVENT_0. Once this PR is merged @jyothees99 will submit the changes on compiler side. Once the compiler changes are in TA we can update the XRT submodule in VE2 to point to this commit.
What has been tested and how, request additional testing if necessary
Tested trace on eff_net design on both hardware and QEMU.
Documentation impact (if any)
NA