Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Combo Event 0 to start trace module for VE2 #8738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parthash0804
Copy link
Collaborator

Problem solved by the commit

As of now we were generating USER_EVENT_0 in CDO to start the trace module for VE2 which was interfering with two of the profiling metric sets.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

How problem was solved, alternative solutions (if any) and why they were rejected

After discussion with @pgschuey and @vipangul we decided to use combo_event_0 which is not being used currently and won't interfere with trace.

Risks (if any) associated the changes in the commit

Changes needs to be done in AIECompiler to start generating COMBO_EVENT_0 in cdo instead of USER_EVENT_0. Once this PR is merged @jyothees99 will submit the changes on compiler side. Once the compiler changes are in TA we can update the XRT submodule in VE2 to point to this commit.

What has been tested and how, request additional testing if necessary

Tested trace on eff_net design on both hardware and QEMU.

Documentation impact (if any)

NA

Copy link
Collaborator

@pgschuey pgschuey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not currently using combo event 0, so this should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants