Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LLM entry point #1145

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Fix LLM entry point #1145

merged 3 commits into from
Jan 4, 2025

Conversation

i-colbert
Copy link
Collaborator

@i-colbert i-colbert commented Dec 31, 2024 •
edited
Loading

Reason for this PR

Recent changes to main.py broke brevitas_ptq_llm CLI entry point.

Changes Made in this PR

Renamed main() to quantize_llm() and created a new main() function without inputs.

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 self-requested a review January 3, 2025 18:57
@Giuseppe5 Giuseppe5 merged commit 349057a into Xilinx:dev Jan 4, 2025
386 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giuseppe5 Giuseppe5 Awaiting requested review from Giuseppe5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-colbert @Giuseppe5