Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FP16 support to ptq_evaluate.py and update README argument list #1174

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

hkayann
Copy link

@hkayann hkayann commented Feb 5, 2025

Reason for this PR

Changes Made in this PR

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

Copy link
Collaborator

@Giuseppe5 Giuseppe5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 quick comments, otherwise looks good!

Thanks again for this.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
'--dtype', default='float', choices=['float', 'bfloat16'], help='Data type to use')
'--dtype',
default='float',
choices=['float', 'bfloat16', 'half'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think half and float16 are equivalent, and for consistency reasons I think I prefer float16.

If I am missing something, let me know please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are functionally equivalent. My initial thought was that using half could help prevent typos, as the only difference is the letter b.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I am trying to save custom-bit-width models, for example FP16 with mantissa 9 bits, exponent 6 bits etc, but seems like not possible given the available PyTorch dtypes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I'm not sure I can fully help with the second issue, since we mostly focus on minifloat quantization with 8 bits of fewer.

In the meantime, would you mind changing half to float16? I understand the potential for typos but I still prefer trying to be consistent across the codebase, and we never (or rarely) use half instead of float16.

Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can simulate for now, so I have a working workaround which is something. I have done all the requested changes as requested. Many thanks again.

@Giuseppe5
Copy link
Collaborator

Thanks for this again :)

I will let the tests run and then merge it

@Giuseppe5 Giuseppe5 self-requested a review February 6, 2025 13:53
@Giuseppe5 Giuseppe5 merged commit 58c3ba9 into Xilinx:dev Feb 7, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants