Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (equalize): enable parametrized scales #1175

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

pablomlago
Copy link
Collaborator

@pablomlago pablomlago commented Feb 5, 2025

Reason for this PR

Enable parametrized scaling, similarly to rotations (see #1148).

Changes Made in this PR

Refactored the function _cross_layer_equalization and incorporated rewriters for handling fused/unfused scaling.

Testing Summary

Created a new test to verify that weights with fused/unfused scaling match.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago changed the base branch from master to dev February 5, 2025 18:35
@pablomlago pablomlago changed the title Feat(equalize): enable parametrized scales Feat (equalize): enable parametrized scales Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant