fix(web: setup): allow forward slashes (non-encoded) repo names in ro…

…utes Resolves issue with NGINX converting encoded forward slash %2F into actual one during proxy pass
YappyBots · Nov 26, 2024 · 97ea379 · 97ea379
1 parent 124c0dc
commit 97ea379
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/Web/setup.js b/lib/Web/setup.js
@@ -166,7 +166,7 @@ module.exports = (app) => {
   );
 
   app.post(
-    '/setup/:id/connect/:type/:githubId',
+    '/setup/:id/connect/:type/:githubId([\\w\\.\\/]+)',
     asyncHandler(async (req, res, next) => {
       const { id, type, githubId } = req.params;
       const { channel_id, github_token, repos } = req.setupData;
@@ -223,7 +223,7 @@ module.exports = (app) => {
   );
 
   app.post(
-    '/setup/:id/disconnect/:type/:githubId',
+    '/setup/:id/disconnect/:type/:githubId([\\w\\.\\/]+)',
     asyncHandler(async (req, res, next) => {
       const { id, type, githubId } = req.params;
       const { channel_id } = req.setupData;
@@ -305,7 +305,7 @@ module.exports = (app) => {
   );
 
   app.post(
-    '/setup/:id/purge/:type/:githubId',
+    '/setup/:id/purge/:type/:githubId([\\w\\.\\/]+)',
     limiter,
     bodyParser.json(),
     asyncHandler(async (req, res, next) => {

diff --git a/views/error.ejs b/views/error.ejs
@@ -27,12 +27,12 @@
 <body>
     <% if (typeof stack !== 'undefined') { %>
         <% if (typeof status !== 'undefined') { %>
-            <h1><% status %> <%= name || '' %></h1>
+            <h1><%= status %> <%= name || '' %></h1>
         <% } %>
 
         <pre><%= stack %></pre>
     <% } else { %>
-        <h1><% status %> <%= name || '' %></h1>
+        <h1><%= status %> <%= name || '' %></h1>
 
         <% if (message) { %>
             <p><%= message %></p>